OSBP 3/8: Making Changes

Open Source Best Practices (OSBP), a crash course for BSc students of Innopolis University.
Blog: www.yegor256.com
Books: www.yegor256.com/books.html
GitHub: github.com/yegor256 (don't hesitate to follow in order to stay informed)
Telegram channel with recent news and updates: t.me/yegor256news (subscribe to not miss a thing)
Twitter with daily and weekly updates: / yegor256 (follow me!)
iTunes: podcasts.apple.com/us/podcast...
SoundCloud: / yegor256
0:00 Introduction
3:27 2013, Bram Adams
8:56 1. Make a small pull request
12:21 2015, Amiangshu Bosu
14:22 2018, Caitlin Sadowski
17:02 2. Don't group your changes
21:46 2020, Carolyn D. Egelman
26:17 3. Insist on code reviews and merges politely
29:13 2020, Marco Ortu
31:16 What is "valence"
37:36 2019, Denae Ford
43:36 4. Be a leader and a boss of a pull request
49:17 5. Mostly explain "why" you make changes, not "what" you change
59:56 6. Be prepared for criticism about your style, not functionality
1:03:00 2021, Valentina Lenarduzzi
1:06:48 7. Commit the code and its tests in different pull requests
1:15:05 Questions and Answers

[@yegor256]

Subscribe, be among the best!
t.me/yegor256news

[@egormerkushev]

1:19:20 на гитхабе где-то в настройках репозитория есть специальная страница для правил, принятых в нем. Можно её заполнить и на нее ссылаться, когда PR им не соответствует.

[@kselnaag2482]

Wanted to ask should I send test with code together in a single PR but it was th 7-th advice =)

[@egormerkushev]

12:06 i don’t agree with point “acceptance will be higher” for small pull requests of one big feature - I think code reviewer need to know a some roadmap to understand the role of isolated small changes in PR. Who and how can provide it to him?

[@n_zveno_economy]

может стоит на родном языке говорить, тогда и просмотров будет на 690, а на порядок больше