Why I DON'T use MediatR in ASP.NET Core

Поділитися
Вставка
  • Опубліковано 17 жов 2024

КОМЕНТАРІ • 52

  • @the-nasim
    @the-nasim Рік тому +9

    I just wanted to let you know how much I admire your approach. Personally, I really appreciate how you emphasize being explicit instead of relying on magic. It's refreshing and exactly what I was looking for. I'm actually planning to incorporate a modified version of your method in my next project, because it just resonates with me. I genuinely can't thank you enough for sharing your valuable insights!

  • @gustavogomes8635
    @gustavogomes8635 Рік тому +1

    The approach you took when you talked about pipelines, look like some kind of decorator implementation using functional programming! Very nice stuff!

    • @RawCoding
      @RawCoding  Рік тому

      It’s just a function passed to another function ) which is more of a strategy. Decorator would be extending “decorating” a type

  • @TheBekker_
    @TheBekker_ Рік тому +2

    Its a bit of a speed run, so will have to rewatch and try this out, but really liking this approach

  • @adrianspikes6454
    @adrianspikes6454 Рік тому

    Good approach with using a high order function. Better to know several ways of solving a problem.

  • @mattdowns358
    @mattdowns358 Рік тому +4

    This works great on a small codebase or when you only need a few commands to have pipelines. For registration I have used scrutor which works quite nicely to wire things up.
    In the end, the most important part of the message here is know why you are doing something and that there are options

  • @VitaliiShmidt-UA
    @VitaliiShmidt-UA Рік тому

    Really good point. Thanks for that. I would probably extend it like with factory probably or fluent builder to express all the pipelines flow exactly in the one place - directly in the endpoint.
    By the way, there also should be some abstraction tho, 'cause You actually can miss some latter or something else and then some of pipeline or handler will not register properly.

  • @shakeuk
    @shakeuk Рік тому +8

    You mighy wanna be careful showing people the service locator pattern without explaining what scenarios this is Okay, it is classed as an anti pattern, though i do feel as though its fair use when building a framework, such as you are here.
    Id hate to see people injecting the ServicPprovider everywhere 😂.

  • @jarnohonkanen4321
    @jarnohonkanen4321 6 місяців тому

    Thanks! I really need to reconsider should I refactor MediatR out of my project. It's easy to use but I don't like the fact that handlers are not visible to caller and it's hard follow control flow from some caller to handler. Too much magic behind to scene IMHO.

  • @manya.korolevskaya
    @manya.korolevskaya Рік тому +1

    Looks good,
    How'd you implement domain events handling without MeditR?

    • @RawCoding
      @RawCoding  Рік тому

      a bit of a depends but mainly queues (channel) and workers.

    • @z0n_
      @z0n_ Рік тому +1

      Wouldn't it be difficult to handle the events inside the same transaction if channels or workers were used? The only reason I would pick MediatR today would be to have the synchronous messaging functionality (notifications).

    • @RawCoding
      @RawCoding  Рік тому

      @@z0n_ you're not going to have a transaction if the domain events are distributed (mediatr doesn't help here). If you need them within a transaction then it can't be channels and workers, you'll have: await Task.WhenAll(handlers.Select(x => x.Handle(event)))

    • @reasyyy-foo
      @reasyyy-foo Рік тому +7

      @@RawCoding it would be interesting if you would explore the subject more and maybe continue with an events dispatching implementation video?:)) i would definitely watch

  • @Nico-lw5ol
    @Nico-lw5ol 3 місяці тому +1

    9:20 What do you mean? This is basic C#. Its a list with some objects that you query using Linq. And I think people learning C# should know key information about abstract classes and interfaces. Was that a joke I didnt catch?

    • @RawCoding
      @RawCoding  3 місяці тому

      yep that was sarcasm, some people are just scared of reflection

    • @Nico-lw5ol
      @Nico-lw5ol 3 місяці тому

      @@RawCoding Ah didnt catch that, my bad. I just couldnt believe it 😂

  • @cocoscacao6102
    @cocoscacao6102 Рік тому +5

    All good, but that reflection linq query formatting. Don't, don't, don't push it all the way to the right. I hate that format, I hate it, I hate it. xD

  • @adrian_franczak
    @adrian_franczak Рік тому +1

    why this pipe instead od minimal api filters?

    • @RawCoding
      @RawCoding  Рік тому

      Filter doesn’t know about model, pipe is your BL

    • @adrian_franczak
      @adrian_franczak Рік тому

      @@RawCoding EndpointFilterInvocationContext has Arguments property

  • @mightybobka
    @mightybobka Рік тому +2

    Why should we use handler classes at all if we can move their code into minimal API handlers?

    • @RawCoding
      @RawCoding  Рік тому +2

      if you need a re-usable piece of logic

    • @swozzares
      @swozzares Рік тому +3

      you can test it without firing up any web server

  • @Sergio_Loureiro
    @Sergio_Loureiro 10 місяців тому +1

    This complexified the program logic for a very little unsignificant performance gain. The mass code is 10 lines difference, which is also insignificant. But the complexity of the code in your approach is harder than using MediatR, So in this specific use case, you didn't convince me to drop it.

    • @bphatness3924
      @bphatness3924 5 місяців тому

      Agreed. In fact, this only further convinced me to just use MediatR

  • @WayneMunro
    @WayneMunro Рік тому +1

    the fewer dependences the better. thanks for this.

  • @roko567
    @roko567 Рік тому +8

    Not really sure what you achieved here. I don't agree with any of the benefits you stated.

    • @RawCoding
      @RawCoding  Рік тому +6

      care to elaborate your disagreement?

    • @ghevisartor6005
      @ghevisartor6005 Рік тому +5

      He achieved explaining that you can have the same if not better result with ur custom code instead of a package that many treat as a must have.
      It's not something like remplementing imagesharp.

    • @adrian_franczak
      @adrian_franczak Рік тому +1

      not using mediator remove magic form code and you can click on all usages

    • @koderkev42
      @koderkev42 Рік тому +4

      ​@@adrian_franczak "Magic"? LoL. Guy talks down on a Mediatr while simultaneously managing database code with EF "Code Migrations" (05:22). What has the developer community become.

    • @NickSteffen
      @NickSteffen 11 місяців тому +1

      @@koderkev42 Yea, of all the “magic” libraries out Mediatr is very straight forward and easy to understand and follow… like it’s really just a bit of boilerplate reduction. Its much easier to follow it than EF Core and automapper. I would much rather use it than make this manually

  • @felixnotthecat4249
    @felixnotthecat4249 Рік тому +1

    Which IDE is this one?

  • @cwevers
    @cwevers Рік тому +5

    Aren't you rebuilding MediatR with this approach?

  • @lucianbumb6690
    @lucianbumb6690 Рік тому +4

    I like your videos very much, but this time you lost the main goal of library like Mediatr. I prefer Mediator because is simple and straightforward.

  • @iuribrindeiro5009
    @iuribrindeiro5009 Рік тому

    I would harder use 30+ classes than using if/ELSE 🤢

    • @iuribrindeiro5009
      @iuribrindeiro5009 Рік тому

      For real now, I would love to see some functional approach example. I’ve been implementing some RoP + kind of the mediator pattern as well and I just don’t see the need to use mediatr yet.

    • @iuribrindeiro5009
      @iuribrindeiro5009 Рік тому +1

      One tip: avoid saying “static” because “seniors” will hate it.

  • @MrJeffrey56
    @MrJeffrey56 9 місяців тому +1

    This is highly suspicious and not good practice.

  • @waheedbhatti0
    @waheedbhatti0 Рік тому

    HowToUseYourBrain LMAO!

  • @cubody
    @cubody Рік тому +1

    Good way to understand how MediatR works. But this approach is like poison for a big project with a lot of requests. Indeed, a mediator can be used without knowing how to build your code architecturally - then it is deadly. But if you know how to use this library, then it saves a lot of effort and simplifies the code.
    For example. I have 30 entities and each has a similar pipeline, I still need to bring everything to some single form. With this solution, I will have to write a unique pipeline and handler for each business process, bearing in mind that it may change someday.
    Again, if I stick Generic everywhere, it will be just as confusing, or even worse.
    The main point is not to use Pipeline Behaviours for everything that moves and does not move. This is a good friend and a good enemy in bad hands.
    It is also worth considering that a separate pipeline for each request in a functional style is far from commonplace in C#, most people programs in an imperative style, there is no need to abuse it...

  • @ddrsdiego
    @ddrsdiego Рік тому +1

    Why build a whole toolkit when there is already a battle-tested tool? For teaching purposes? I agree! for production? Don't reinvent the wheel.

    • @RawCoding
      @RawCoding  Рік тому +1

      Toolkit? It’s a higher order function