Це відео не доступне.
Перепрошуємо.
Top 5 Angular Mistakes - You Must Know Them
Вставка
- Опубліковано 25 сер 2021
- Learn top 5 Angular mistakes in 10 minutes. Here I want to share 5 most common Angular mistakes that people do. If you avoid this mistakes you can code faster, be more productive and achieve your goals.
► CHECK MY COURSES - monsterlessons...
FOLLOW ME
► TWITTER - / monster_lessons
RECOMMENDED VIDEOS
► My editor setup for web development - • Best Text Editor for W...
► Angular Tutorial for Beginners - • Angular Tutorial for B...
► Vue JS Crash Course - • Vue JS Crash Course fo...
► React Hooks Full Course - • React Hooks Tutorial f...
► Typescript Course for Beginners - • Typescript Crash Cours...
► Build a Todo App with Angular - • Build a Todo App With ...
► Creating custom select library - • Custom Javascript Drop...
► HTML Price comparison - • Practice CSS and HTML ...
► How to build Quiz with React hooks - • How to Build a Quiz Wi...
MY COURSES
► NestJS course - • Nestjs Tutorial: Build...
► Docker + Docker compose course - • Tutorial Docker Compos...
Disclosures: All opinions are my own. Sponsors are acknowledged. Some links in the description are affiliate links that if you click on one of the product links, I’ll receive a commission at no additional cost to you.
Learn most popular Angular interview questions - ua-cam.com/video/MSAiCicJWQA/v-deo.html
My Problem with the Streams,
Is how do I catch Error,
just use try catch?
to promise it seems easy,
just .catch you get the error,
but in these it seems different
@@TD-sh6wd Just use catchError
www.learnrxjs.io/learn-rxjs/operators/error_handling/catch
title of the video should be "top 5 mistake developer makes in angular"... its not angular mistakes
0:10 Subscribe Instead of Streams
4:26 Unsubscribe
5:33 Not Enough TypeScript
6:47 God Object Modules
7:49 Performance: TrackBy
Thanks a lot!
Have watched several videos with this Author (name?). This is something real high quality. I am an experienced programmer and have even worked with Angular for some time and still this was very much worth watching. He has a God given talent of making coding videos.
This series should have 1000s of likes.. really amazing well explained . Very well edited everything is not too long and not too short.. It is a real pleasure to watch and learn from. Also by following these videos you pick up good coding practices with an understanding of why!
I'm coming from a React background and now am starting to learn Angular and I most say these subscription feel unnecessary to use everywhere. They are very useful when data gets updated again and again like a stream. But when I just want to fetch a single value from the api.. why do I need to subscribe to it. A promise is all I need. I turned to using the firstvaluefrom from rxjs in the service and turning the requesting method in the component into a async method. Now I can utilize async/await and try catch blocks . I don't know if it's wrong, the reason "it is the angular way" is not really an answer. Angular has changed it ways allot with every update.
I agree with you. When we fetch data it doesn't make a lot of sense of stream. But the idea is that everything is a stream: DOM events, API calls, data streams. Then it is much easier to combine this data. If you convert it to promise you can't combine it.
About the first point: the use of streams and async-pipe is really nice - UNTIL you realize that there is a thing called "error handling"! It's save to save that you want some sort of error handling in every single async call - at the very least this will reset your "loading"-indicator (like a spinner), but it might also display proper messages to the user.
This is were async gets ugly - very badly so - you need a second stream, operators to share the original subscription and so on. You CAN do it, but in the end it does get quite bloated. Please show the ugly parts as well when recomending async-pipes.
Other than that: nice video!
Hi thanks for your comments but it sounds like your architecture is not correct.
isLoading$ stream doesn't know anything about errors and it should not.
errors$ is rendered when we got errors and saved them in state.
What you wrote is promise approach when you need to render something when you get an error. You need to separate fetching/errors from state rendering. Then you won't have problems.
@@MonsterlessonsAcademy I will try to explain better: A real world example would usually at least have a loading-spinner to show the loading process and would have to catch and display potential errors in some way, doesn't it?
What happens if your this.userService.getUsers() function actually throws an error? Let's say because you lost your internet connection for a minute.
My point is that async is only THAT beautiful if you neglect error handling - once you add that it get's pretty ugly - especially if you want to handle it fully reactive.
The simplified variant is this:
this.userService.getUsers().subscribe() => {
next: () => this.isLoading$.next(false),
error: (err) => this.error$.next(err.message)
}
And we render
{{isLoading|async}}
{{error|async}}
Wow, been coding Angular for 2 years and I’ve been doing it all wrong. 😅 thanks for making this video!
Happy to help!
Thanks for pointing the common mistakes and giving detailed solutions for each of them, helped me a lot! Subscribed
Thanks for the sub!
Please use the async pipe xD
Thanks, this video helped me understand the angular design pattern better.
Glad it helped!
It's a good tips. Oleksandr, I have a question to you: why do we initialize our values in the constructor and not in the lifecycle hook OnInit? Because ngOnInit was created just for this. Isn't it bad code style to push variable initialization into a constructor?
Yes you are write. onInit is "better" because it's an Angular life cycle hook and constructor is a default behaviour of the class.
The main problem with strict typescript you get error that your values doesn't have initializer when you write
isLoading$: Observable | undefined
ngOnInit() {
this.isLoading$ = this.store.select(isLoadingSelector)
}
and you get all boring undefined checks in your component.
When you write assignment in constructor TS doesn't scream because it's a default value and it can never be undefined.
@@MonsterlessonsAcademy , you're right. Thanks!
@@MonsterlessonsAcademy actually it can be resolved like this
sLoading$!: Observable;
ngOnInit() {
this.isLoading$ = this.store.select(isLoadingSelector)
}
This is actually just a common pattern when using DI (following SOLID principles is not a bad practice). It's important to keep in mind why _change detection_ lifecycle hooks exist: There's something we want to happen in the template at the appropriate time. ngOnInit was created to initialize "all data-bound properties of a directive", but it's called _after_ object construction.
Thanks. These are the mistakes I've been doing for the last 4 months since when I started writing Angular code.
You are welcome!
For the second problem: you don't need unsubscribe subscription from http client requests. These are single subscription and are cleaned up by the http client itself.
You are totally write but nobody knows what is inside service. It might be not http. I prefer to always unsubscribe from all subscribes to be on the safe side.
@@MonsterlessonsAcademy should i use it for unsubscribe angularfire ?
@@sugiono2801 I would unsubscribe from any subscribe in my app just to be on the safe side.
http emits once and complete or error. So no need to unsubscribe, please refer to angular document. the same for routing and its observables.
When i work with behaviour subject i need to unsubscribe likr you but i love the obsevable way nice bro
thanks a lot for your videos, easy to understand straight to the point. I'm transitioning from react, they helped a lot!
You are welcome!
Thanks my friend, GREAT video. Thanks a LOT.
Glad you enjoyed it!
Wow! This is really helpful 👌, thanks for sharing. I'm guilty of subscribe instead of stream, I can only use it effectively when I want to fetch data, but how do I use streams for updating, deleting and creating data or generally CRUD operations? Thanks
You can learn more about streams, RxJS in my course as we have lot's of crud operations there.
ua-cam.com/video/DyklxnC2XP0/v-deo.html
Thanks for these helpful tips, what if I used track by index instead of creating function inside component?
What is track by index?
I had to watch a crap Mano Mano ad to see this video but it was worth it!
Sorry for that but because of you more videos will come and you will get new quality free content.. I think it's a fair deal :)
cool video mate, i havent used the trackby function!
You should!
Nice, a newly found Angular content creator 🤩 (or at least partly). Will sub an see if you'll continue putting out advanced Angular tutorials. Looking forward!
Welcome aboard!
Thanks a lot man, that's really helpful stuff
Glad it helped!
thanks for your videos
when we use stream instead of subscribe what if we need to make loading or error happened how to handle this
It depends. Something still needs to read a stream. Either a subscribe or async pipe. If you want to handle error you can use catchError function. Loading it typically a separate stream, or a stream which returns loading status.
Awesome, thanks for sharing!
Thanks for watching!
Great content. Earned yourself a subscriber.
Just a bit skeptical about the shared module cause even Angular recommends it.
It's up to you. There is never a silver bullet. If you have 5-10 components in shared you won't have any problems and it's fine. It's not fine when you have there 100 components, services and modules.
@@MonsterlessonsAcademy true that is why services should not live in shared.
Would love to see you cover ngrx component store. At a global and component level.
@@g-luu Thanks for the idea!
Using the async pipe method how would you handle errors? Maybe my question is too broad and requires its own tutorial which would be very welcome. Thanks for the video
Typically you have 2 async pipes for data and for error. You either fill data stream or error stream,
there is an rxjs operator for this - catchError
@@krzysztoftokarz3684 isn't it deprecated
Another amazing video!! 🔥🔥
Appreciate it!!
Very good tips. I've learnt a lot. Thanks very much for this video.
Glad it was helpful!
Is it necessary to declare the observable in the constructor? I have always declared it in the ngOninit. What's the benefit ?
If you declare a property in the component you can't declare it in ngOnInit, only in constuctor or inline. If you set a value in ngOnInit the initial value is undefined.
This has really helped correct some of my mistakes, thank you. Please, I must know, What font are you using in the editor?
You are welcome! It's monaco font.
I'm humbled and inspired.
Awesome!
Useful Thank you !
Glad it was helpful!
The accent makes understanding difficult. The topic is important. Plz consider keeping the video and re-recording the audio track. I tried the CC feature, and it confirms the problem: "rick cheers" within 30 secs of the start.
Salute bro
isnt it better to initialize values in OnInit rather than the constructor?
No as they are undefined then. If it is what you want then you can do it.
I'm happy, I discovered your channel today. Subscribed!
Any chance you show us your vim setup? Many thanks!
Here is the video about my Vim setup. configs are in the description.
ua-cam.com/video/YrLiugDhCuk/v-deo.html
@@MonsterlessonsAcademy Sorry I didn't notice this video. Many thanks.
Thank you so much.
You're welcome!
Very helpful, thanks
Glad it was helpful!
Regarding first example with async pipe, what if you want to display a loading spinner while data is being fetched? how you do that with no subscriptions in an easy way (without using interceptors)?
I create several streams. isLoading$, data$. I would create behaivour subject or use ngrx for that.
Your new follower 😊
Welcome on board!
The observable approach looks great but if we need to perform any action like run a function on new data before assigning data to users object should we use subscribe or is there anyway to do that with an observer
"Run a function on new data" is exactly a subscribe.
Rerender data in template on observable change is
{{someFoo$ | async}}
So for everything except of "Run a function on new data" it should be async pipe and for that case subscribe.
@@MonsterlessonsAcademy Thanks 👍🏻
As usual,very helpful
Glad to hear that!
very good videos. you should make more.
Thank you, I will
In your first example code looks pretty simple which is fine. But how can I add some loading indicator on the page with this? For me it looks like it is much easier to implement loading indicators with promise
It's the same
this.isLoading = true
this.getUsers().subscribe(users => this.isLoading = false)
@@MonsterlessonsAcademy Thanks, I see this will work.
I know rxjs is "angular way", but I still don't see any real advantages besides "do it in observables because this is angular way". Watched few angular courses, and a lot of tips and tricks angular videos. We started migrating some old pages to new angular, and I am doing everything in promises.
What do you mean by scalable? Doesn't 1 app run on 1 device on the client?
By scalable I mean that you can add more complexity without your app to become unsupportable.
Super important
Thanks!
How make "subscribe instead of streams" if my service returns an Observable
It doesn't mean you must eliminate subscribe completely from API. Sure subscribe for API calls is fine but people are overusing it a lot.
which vscode theme is this?
It's gruvbox
How to handle the situation when you have 1000 components in SharedModule? Mayb you can do a video about solution to question #4?
Just don't do it. Split it by logic to different modules and don't create sharedModule at all.
what theme of your vscode?
It's gruvbox theme and vim editor. Here is a video about it
ua-cam.com/video/YrLiugDhCuk/v-deo.html
Another common mistake is to put too much in the ngOnInit. You can not do things that subsequently modify the DOM until the DOM is fully initialized. These will be ignored.
Yeap!
@@MonsterlessonsAcademy I had to look that up. Yeap indeed!
Devs have to be careful when use change detection
How to test it? I mean the first case
I made a video about it with steps to reproduce
ua-cam.com/video/wDAmfqnIrck/v-deo.htmlsi=2D9Wh9JQJ-JTBKXo
You are completely wrong about ngFor - of course it does NOT re-render all elements when one is changed. And that can be easily verified. Object equality is used as tracking function by default.
Another thing related to that users$: If that observable is actually http call (which nearly always true) you should not bother unsubscribing at all in most cases. Also if its http call your component behavior starts to depend on template (http observables are lazy and request is not fired when no subscriptions - and you have none in component class...) which is never good. Also u have no direct access to users length or to any element in component class. Taking all that into accout, I am very unsure that what you showed is a strong MUST -- its just opportunity, no more.
Thanks for your comment. It looks like you have good experience and you can make good decisions on your own. A lot of Angular devs which I see every day don't have that so they need some strict rules to write better code.
no timestamp ...
ROFL I had an interview and ... yeah I should have watched this video before... cause everything I didn't have an answer to is in there...
But now you watched it so just wait for the next interview :) Or even prepared to it with my full course of Angular questions
monsterlessons-academy.com/courses/angular-interview-questions-coding-interview-2023
your accent is cool , where are you from?
Originally Ukraine but already long time Germany
Нормальное видео)
hey that's my code
Bro are you croatian or serbian?
Ukrainian
If I am right, you could even remove the code from constructor (this.users$ = ...) and move it all to th class
hi sir . i took your ngrx course . we need angular course from you sir
Thanks for the idea, I will add it to the plans of future courses.
@@MonsterlessonsAcademy thank you sir. Expecting angular course in the future 😊
Subscribe? Wow that is very interesting
Glad to hear that!
and 1 more: write logic inside OnInit not in constructor
That depends. If you won't get properties for example from route in constructor you will need to handle all undefinds in your component. I prefer to do such things in constructor as well as assigning streams.
choosing angular was my first mistake
I was very comfy with JavaScript but when I used Angular I learned more about TypeScript and I'm not looking back.
Angular feels really robust but I totally get that you have to learn a lot of new things and thats time consuming when you're in a new project
But "Tour of heroes" looks exactly like the bad example.
It is beginners level and not the patterns which are suitable for big apps.
Mistake 1:
How do you do things after a value change if there is no subscribe?
```
filters$: Observable;
constructor(private eventBus: EventBusService) {
this.filters$ = this.eventBus.getChannel('filters')
// do something when we have filters
}
```
previously I'd do:
```
filters: string[] = [];
this.subscription = this.eventBus
.getChannel('filters')
.subscribe((data) => {
this.filters = data;
// do stuff
});
```
Your approach is cleaner but I am not sure how it applies when you actually want to do stuff after the stream returns the values.
Do something is always subscribe. Update your values and rerender them in template not. In 90% cases you want rerender and not a function call.
@@MonsterlessonsAcademy Sweet thanks for sharing
Guess what is the Tour of Heroes way of introducing Angular?
this.heroService.getHeroes().subscribe(heroes => this.heroes = heroes);
To be fair, it becomes quite hard to use streams directly as soon as you need to do anything more complex with it, like combining different data sources etc.
Yes Angular and stream are not easy but this is what we have. This is why typically Angular is being paid better than React for example