STOP SWALLOWING EXCEPTIONS 🤮

Поділитися
Вставка
  • Опубліковано 16 чер 2024
  • Java Exception handling is key for any backend application. In this video I discover this flaw in a code review.
    Please never do this.
    Don't Forget to
    ===========================================
    💯 Subscribe to Amigoscode - bit.ly/2HpF5V8
    💯 Courses Available for free here - amigoscode.com/courses
    💯 Join Private Facebook Group and Discord - amigoscode.com/p/join-community
    🙊 Here are the goods for all my videos video 🙊
    ► Recommended Books
    ===========================================
    - Clean Code - amzn.to/2UGDPlX
    - HTTP: The Definitive Guide - amzn.to/2JDVi8s
    - Clean Architecture - amzn.to/2xOBNXW
    ► Computer and Monitor
    ===========================================
    - New Apple MacBook Pro - amzn.to/3464Mmn
    - Dell 27 INCH Ultrasharp U2719D Monitor - amzn.to/2xM3nW1
    - Double Arm Stand Desk Mount - amzn.to/3aYKKfs
    - USB C Hub Multiport Adapter - amzn.to/2Jz7NlL
    ► Camera Gear
    =============================================
    - Sony ILCE7M3B Full Frame Mirrorless Camera - amzn.to/346QIJn
    - Sigma 16 mm F1.4 DC DN - amzn.to/2wbic3Q
    - Sigma 33B965 30 mm F1.4 DC DC - amzn.to/39G37Fd
    ► IDE & Tools I use for coding 💻 🎒
    ===========================================
    - ITerm
    - VsCode
    - GoLand
    - IntelliJ Ultimate
    - Sublime
    P.S
    ===========================================
    💯 Don't forget to subscribe | bit.ly/2HpF5V8
    💯 Join Private Facebook Group and Discord - amigoscode.com/p/join-community
    💯 Follow me on Instagram | bit.ly/2TSkA9w
    ❤️ Thanks for watching
  • Наука та технологія

КОМЕНТАРІ • 74

  • @praveens2272
    @praveens2272 Рік тому +10

    I always tell my juniors never ever swallow exceptions, in rare cases we don't need to rethrow or wrap it. We could just log the error.

  • @89Valkyrie
    @89Valkyrie Рік тому

    Incredible advice. Thank you.

  • @oogway_hussein
    @oogway_hussein Рік тому

    thank you, your video teaches me using intellij and luckily, the shortcuts are same than pycharm, it is better slowly learning intellij for me than looking at the pdf and i don't forget easily this way

  • @orionpaul5210
    @orionpaul5210 Рік тому

    thanks Nelson I actually dropped nodejs back to springboot saving some little fund for your master class you make Java go simple

  • @MsSWAGboss
    @MsSWAGboss 9 місяців тому

    GREAT content!Keep it up👏👏

  • @GabrielSoares-mt5il
    @GabrielSoares-mt5il 15 годин тому

    Great video, bro!

  • @codertravel99
    @codertravel99 Рік тому

    You are always awesome Nelson ❤️❤️❤️

  • @vitormuuniz
    @vitormuuniz Рік тому +21

    STOP SWALLOWING EDITION! IT WAS MUCH BETTER THE OLD WAY

  • @Asingh42
    @Asingh42 Рік тому +1

    Hey! Been watching your tutorials since a long time.. Can you make tutorials on reactive programming using spring web flux ?

  • @divakarpandey9094
    @divakarpandey9094 Рік тому

    Grt bro !! Thanks for the suggestions
    I am ATG developer from India. Sometimes I do like this.

  • @Take19797
    @Take19797 10 місяців тому

    the try and catch was made for the .save method except that method could also throw its exception if it faced error while logging in the database so really there was no need for the try and catch unless the catch had something useful to do which didn't in this case but also sometimes the the handler (try-catch block) is made by force because the .save method can throw an exception therefore the API enforces the rule on you

  • @martingomes8641
    @martingomes8641 Рік тому +7

    Sometimes we need to handle checked exceptions from an external API and it enforces you to use try-catch Block, i think the appropiate way in this case is retrow the exception. I also agree with the approach of handle exceptions with proper status code.

    • @martingomes8641
      @martingomes8641 Рік тому +6

      Another thing to be aware is to not rethrow complete exception, sometimes exceptions have sensitive data to be exposed.

    • @dunayqudretli3382
      @dunayqudretli3382 Рік тому

      yeah, In checked exceptions you don't need to catch exception also, just throws exception to the spring boot, then handle it from advice and return according status code to the client

  • @devoiddude
    @devoiddude Рік тому

    Could you do a demo on this please? very interesting topic.

  • @Asingh42
    @Asingh42 Рік тому +1

    The starting sequence was hilarious 😂😂

  • @jeick3645
    @jeick3645 Рік тому +1

    thank you Jedi master

  • @sainarsimhaguptathammana9908
    @sainarsimhaguptathammana9908 Рік тому +3

    Hi Nelson,
    Thank you🤝 for the wonderful lessons.
    I am a java developer, currently i have been working on one project where I have to process/validate against 50-60 rules, each rule is created as a class due it's complexity. Now these many classes I have to inject into the service class for the processing...
    In the service class I am using the switch case to process the desired rule.
    Could you please suggest any solid dependency injection pattern or another way here.
    Thank you in advance!

  • @lengors7327
    @lengors7327 10 місяців тому

    The amount of code I've looked at that doesn't swallows exceptions and doesn't use status code or uses it poorly since I started working on the industry is astonishing (and I've been working for 5 months only lol). But not so surprising when I've had to work with APIs that use GET requests to put/post/patch data

    • @orlandolorenzodeveloper
      @orlandolorenzodeveloper 6 місяців тому +1

      Yep, same here When I have some time, I just do refactoring work and then create a new branch with the refactored code ready to be merged with the main branch (of course I write tests before changing anything complex)

  • @imdadabro4118
    @imdadabro4118 Рік тому

    Great one.

  • @vidhya821
    @vidhya821 Рік тому

    separate video on exception handling will be appreciated

  • @maroofali4723
    @maroofali4723 Рік тому

    The 200 OK example is hilariuos 🤣🤣🤣

  • @jamesraphael8473
    @jamesraphael8473 Рік тому

    Thanks bro ❤

  • @abu-dukhan
    @abu-dukhan Рік тому +1

    Thanks man.
    I hope the we all learn something here which we have in Sha Allah.
    And please Nelson, can you make a video on multiple implementation of UserDetaisService and a custom authentication provider so that one can authenticate users from different tables.
    I think that will help a lot, because I'm struggling to do that for about 3 to 4 days now, I did some research and the only thing I found was I have to use WebSecurityConfigurerAdapter which is now deprecated.
    It'll be a big help if you'll do that for use, especially me. JazaakAllahu khairan.
    May Allah increase you in knowledge and wisdom.
    Assalamualaikum

  • @ranjanpandey2225
    @ranjanpandey2225 Рік тому

    He might be hungry. So he swallowed the whole exception😂❤

  • @somebodyoulove
    @somebodyoulove Рік тому +1

    In a case where the code is unable to save to the DB say a network connection issue or DB is out or down won’t the try catch come in handy. Or does he/she check at every instance if the DB connection is up/accessible before saving into it.

    • @FG-td4vs
      @FG-td4vs Рік тому

      no, a 500 error should be returned in the case of an error like that

  • @UberDurable
    @UberDurable Рік тому

    Nice tip, and I have a selfie with Cameron Diaz!

  • @jamalkb5912
    @jamalkb5912 Рік тому

    it's okay because client side code can handle the returned value

  • @centfox
    @centfox Рік тому

    1:56 Could you please tell us why the try-catch is not needed when there is no checked exception? What if the persistence fails?

    • @ds_world2468
      @ds_world2468 Рік тому

      He means to say that do not send status code 200 if any exception is occurred. Handle and throw an appropriate status code and message here or use controlleradvice for the same

  • @michatchorzewski4272
    @michatchorzewski4272 Рік тому

    Heh I saw something like this in production code... Fixing this is painful

  • @friedec3622
    @friedec3622 Рік тому +1

    statuscode: 200
    message: "Mission failed successfully"

  • @khazsilverstar
    @khazsilverstar Рік тому

    What about an exception thrown in a secundairy non-business critical process? Thow it upstream and catch it at the uppermost service level?

  • @rrrel756
    @rrrel756 Рік тому

    I'm not familiar with java. But shouldn't employeeRepository.save(employee) be checked for insertion error?
    Does the JPA automatically throws an error?

    • @thejavaacademy-18
      @thejavaacademy-18 Рік тому

      Actually Jpa doesn't automatically throw errors. But then you have the option to handle errors in your service class as well as use some quite useful annotations for input validation.
      All of these ensure you won't have an error while saving an object

  • @Quillraven
    @Quillraven Рік тому

    At least he was logging something. I saw code where the developer just added a comment in the catch block like // ignore.
    Most likely he thought that this error will never happen but unfortunately it did and it took me quite some time to find that place and finally be able to debug it and fix the problem.
    It was some parsing shenanigans with date and number and obviously the format changed at some point which made his code no longer work 😅

  • @default_client
    @default_client Рік тому

    i was doing this last friday hahahaha and i made the error harder to identify

  • @caffeinejavacode1475
    @caffeinejavacode1475 Рік тому +8

    Guys Interview question for you: Why there is no cheched exception here, do we need, what about SQLException?

    • @nghiao4427
      @nghiao4427 Рік тому

      Wait someone

    • @caffeinejavacode1475
      @caffeinejavacode1475 Рік тому

      @@nghiao4427 I know answer but video not cover this topic

    • @nghiao4427
      @nghiao4427 Рік тому +1

      @@caffeinejavacode1475 Oh so what is answer? Please tell me

    • @minimovzEt
      @minimovzEt Рік тому +1

      Most likely handled by a exception handler class, you will intercept most common exceptions there and only rethrow if you need a specific or custom exception

    • @breakofsadness9629
      @breakofsadness9629 Рік тому

      Hibernate wraps it in the Runtime Exception?

  • @martinmiano8220
    @martinmiano8220 Рік тому

    I will admit that I do this when creating microservices. Generally, I record a request to the appropriate request table and if and when it fails, I curate a response code and message that details exactly where the action failed. I prefer to curate detailed response code and message rather than just error 500 that show just that an internal exception occurred.

  • @dixztube
    @dixztube Рік тому

    lol I can see why folks don’t ask for help

  • @sacmaliyoruz
    @sacmaliyoruz Рік тому

    the real problem is exceptions :)

  • @heyyrudyy404
    @heyyrudyy404 Рік тому

    I heard exceptions making everything exceptional… so I proceeded to swallow them all 😋

  • @im_aditya_rathi
    @im_aditya_rathi Рік тому

    What's wrong with the code, I wasn't able to find it.
    Why does this give the error in case of status 200. The catch block will only execute in case it finds any Exception then why this is wrong. (can someone explain to me)

    • @friedec3622
      @friedec3622 Рік тому +1

      The server will send 200 OK to the client, regardless the request is fail or successfull. Since the catch only log the error.
      Moreover, it will save null data to the database.

    • @im_aditya_rathi
      @im_aditya_rathi Рік тому

      Thanks Friedec,
      I got it now 😊.

  • @jameszaman3326
    @jameszaman3326 Рік тому

    Anyone know what IDE and font he is using?

  • @gustavotargino6336
    @gustavotargino6336 Рік тому +1

    200 = failed successfully

  • @guyswithhoodie3572
    @guyswithhoodie3572 Рік тому

    why did you remove my course from the website which I paid for. and now since you increased the price of that course you are offering me only $15 refund. This is not acceptable.

  • @test9828alpha
    @test9828alpha Рік тому

    LGPTQ+ and muslim how come ?

  • @hamdiaminehkh
    @hamdiaminehkh Рік тому

    hi,
    For my case i send as response an Object named ReturnObject = {"codeException": , "messageException": , "data"} with code 200.
    if there is no exception the "data" attribute contains the Result Object . if there's an excetion i send codeException and messageException.
    So allways i have ResponseStatus = 200.
    And in FRONT i manage the response in Interceptor.
    If i do this , it's considered as a swallow exceptions?

  • @garbi..
    @garbi.. Рік тому

  • @sagargandale4510
    @sagargandale4510 Рік тому

    novice code just like me but i do little bit better

  • @bayembackembaye8969
    @bayembackembaye8969 Рік тому

    😂😂 amazing

  • @ericbroun4657
    @ericbroun4657 Рік тому

    آفرین

  • @mm1nt
    @mm1nt Рік тому

    Like ur vids but you are editing too much, its not it

  • @Rubik1325
    @Rubik1325 Рік тому

    I dont know if this was a Java or After Effects tutorial, so annoying