I Do this for every commit and why you should too!

Поділитися
Вставка
  • Опубліковано 8 лис 2024

КОМЕНТАРІ • 27

  • @Leyksnal
    @Leyksnal Рік тому +2

    I really learn a lot from watching this video such that i want to watch again and again because I'm still trying to set up the whole thing for the first time , please can you make another video to talk more on setting it up from scratch on a new project. Thanks

  • @dealloc
    @dealloc Рік тому +8

    Blocking commits encourages people to create large commits, rather than smaller refined ones, because no-one wants to wait around for your darn linting and type checking. It slows your workflow and train of thought.
    If you don't want to include fix commits like "typo" and "formatting", use rebase to clean up your commits when it's ready for review, and amend commits.
    At maximum I consider a non-blocking commit lint rule like prettier and only run it on changed files-but my editor does this anyway. Everything else like ESLint and TypeScript are slow because they have to run across your entire codebase in order to catch actual issues. Use your editor and CI pipeline to get notified about errors and warnings before merging your pull requests.

  • @TormentaNocturna
    @TormentaNocturna Рік тому +1

    Thank you for your explanation. Excellent video.

  • @MrJoaopaulofurtado
    @MrJoaopaulofurtado Рік тому +5

    I like the idea of linting comments, but my impression is that its just "one more thing" to slow people down.

  • @Shuyinz
    @Shuyinz 2 роки тому +1

    The git commit linting is very useful! How can you Config if you want the git commit starts for example "GS-123" before using "add: new card", so it would be like "GS-123 add: new card"?

  • @regilearn2138
    @regilearn2138 2 роки тому +1

    hi pls do,updated video on set up linter,prettier,huzki for react app anf include this also

  • @bobdpa
    @bobdpa Рік тому

    Awesome stuff

  • @3aQaRyAn
    @3aQaRyAn Рік тому

    Thank's😉😉

  • @rahulreddy-ynr
    @rahulreddy-ynr Рік тому

    ❤awesome man

  • @theshubhampatidar
    @theshubhampatidar 2 роки тому

    Hello, Can you please share the Extention list ??

  • @joselima7655
    @joselima7655 2 місяці тому

    Does any one know what colorscheme this is ?

  • @rishiraj2548
    @rishiraj2548 2 роки тому

    Good day

  • @tomaszp2580
    @tomaszp2580 Рік тому +1

    No you not need it. Fot sure if you squash commits. If you want do something like this better to move it to ci piplines.

  • @drdev_blog
    @drdev_blog 7 місяців тому

    2024 it doesnt work like this, Inctead use:
    create commit-msg file im the .husky folder and add
    npx --no -- commitlint --edit \
    there and delete pre-commit file

  • @sarcasticdna
    @sarcasticdna 2 роки тому +3

    @theo will disagree with you 😅

    • @RaZziaN1
      @RaZziaN1 Рік тому +1

      theo was talking about linting everything, in this case u are linting only staged.

    • @ky3ow
      @ky3ow Рік тому +1

      @@RaZziaN1 its still blocking developer from commiting his work, even if its temporary commits that won't be pushed anywhere, so it seems really annoying

  • @nanangkho9378
    @nanangkho9378 Рік тому

    What theme vscode ?

  • @anhdunghisinh
    @anhdunghisinh Рік тому +3

    Man @Theo will get cringe at this video.
    Don't do this mate, what you should do is create a lint CI CD on server, not on local. Doing this on local will block everyone in your team and slow them down, the dev will throw middle finger behind your back in no time.
    Unless you are working on a project alone, this is a very stupid idea to do.

    • @odevrenan
      @odevrenan Рік тому +1

      It is to keep the code style in sync, I guess

    • @anhdunghisinh
      @anhdunghisinh Рік тому

      @@odevrenan nah, you want the code style get sync? Let people manually change the config, don't let the linter control it. The config you change once and it will always be the things you want, but with the linter, it will run everytime, even if your code is already clean.
      Also i said move the linter to the github action or sth similar, it run on server and only run when you push, reduce the time linter have to run a lot.

    • @MatheusEstevao-X
      @MatheusEstevao-X 7 місяців тому

      You all riding Theo like a fucking religious cult.

  • @alext5497
    @alext5497 2 роки тому +4

    Uninstaller prettier is the best decision I ever made