"Make sure that the code-reviewer is focusing on separation of concerns first" - this is the best advice I can think of in terms of CR 👏. Sadly most of the times you just get approved and person claims that there is no time for proper CR since there are deadlines 😤. Careless approve is even worse than bad review (focused on useless things)
Thanks! And yes, agreed, a careless approve is hurtful for code quality (and people!). One way of avoiding it, is to do a 2-part codereview: first have a videocall or face2face chat together about the SoC and general solution design where the reviewer explains the interfaces/coupling/etc. verbally, and only after that there's a line-by-line review done by the reviewer alone. I've talked about this in my first-ever video on this channel, if you can work yourself through the bad quality of that 🤦🏻
"Make sure that the code-reviewer is focusing on separation of concerns first" - this is the best advice I can think of in terms of CR 👏. Sadly most of the times you just get approved and person claims that there is no time for proper CR since there are deadlines 😤. Careless approve is even worse than bad review (focused on useless things)
Thanks! And yes, agreed, a careless approve is hurtful for code quality (and people!). One way of avoiding it, is to do a 2-part codereview: first have a videocall or face2face chat together about the SoC and general solution design where the reviewer explains the interfaces/coupling/etc. verbally, and only after that there's a line-by-line review done by the reviewer alone. I've talked about this in my first-ever video on this channel, if you can work yourself through the bad quality of that 🤦🏻
This is VERY HELPFUL. I have been having a difficult time explaining this esp with looming deadlines.
thanks for the clear explanation!
Thanks for sharing!
Awesome , keep going!