22:26 BookDetails component depends on the internal structure of the store. What if we decide to have several carts or just rename it? We'll have to find all components where it is used. What if in some component we separated 'shop' from 'cart'? We wouldn't have any common pattern to find such entries. It reminds me immutable that tends to poison all parts of code with its API and it is very hard to find such places. I think that view components should know nothing about the external state and just invoke passed addBook() property. Some outer component (container) may connect it to the store. Same for BookEntry. It depends on shop.view.openBookPage blocking any refactoring of internal structure of the store. I think it should just invoke onClick property.
Regarding renaming. With modern IDE you simply use refactoring option Rename and it renames specific symbol everywhere in your codebase. Also with use of TypeScript you will probably get warnings in every place you forgot to rename it.
This talk is the real eye-opener! :)
22:26 BookDetails component depends on the internal structure of the store. What if we decide to have several carts or just rename it? We'll have to find all components where it is used. What if in some component we separated 'shop' from 'cart'? We wouldn't have any common pattern to find such entries. It reminds me immutable that tends to poison all parts of code with its API and it is very hard to find such places. I think that view components should know nothing about the external state and just invoke passed addBook() property. Some outer component (container) may connect it to the store. Same for BookEntry. It depends on shop.view.openBookPage blocking any refactoring of internal structure of the store. I think it should just invoke onClick property.
Regarding renaming. With modern IDE you simply use refactoring option Rename and it renames specific symbol everywhere in your codebase. Also with use of TypeScript you will probably get warnings in every place you forgot to rename it.
Thanks for that.
ShopStore