I've had pretty bad experiences with code reviews. Only rarely did they find issues. The long term productive employees had review buddies, so they were never slowed down and those reviews actually only brought up important issues. But for newer employees the reviews were used to slow things down so that the team could handle the rate of change, not look unproductive themselves, or to manage the technical direction without having to come up with designs and defend them ahead of time. I've even been on a team where every other developer felt compelled to ask for at least one change, and the original developer had to satisfy every one else. They really believed that you should research everything to death, then merge a feature one time, and never revisit past decisions. I was let go when I proposed that some of the comments could be addressed in the next iteration. No fit for the culture!
I've had pretty bad experiences with code reviews. Only rarely did they find issues. The long term productive employees had review buddies, so they were never slowed down and those reviews actually only brought up important issues. But for newer employees the reviews were used to slow things down so that the team could handle the rate of change, not look unproductive themselves, or to manage the technical direction without having to come up with designs and defend them ahead of time. I've even been on a team where every other developer felt compelled to ask for at least one change, and the original developer had to satisfy every one else. They really believed that you should research everything to death, then merge a feature one time, and never revisit past decisions. I was let go when I proposed that some of the comments could be addressed in the next iteration. No fit for the culture!
Found some better place? Culture in the workplace is often the defining factor of job satisfaction: often talked about rarely cared for :(
first